Opened 10 years ago

Closed 10 years ago

#96 closed defect (fixed)

When notify() is called for a new note, getNote() on the item returns false

Reported by: david Owned by: dstillman
Priority: minor Milestone: 1.0 Beta 1
Component: data layer Version:
Keywords: Cc:

Description


Change History (3)

comment:1 follow-up: Changed 10 years ago by dstillman

  • Resolution set to fixed
  • Status changed from new to closed

(In [320]) Fixes #96, When notify() is called for a new note, getNote() on the item returns false

getNote() now returns an empty string rather than false on a new item

David, I assume this is what you meant--if not, reopen

comment:2 in reply to: ↑ 1 Changed 10 years ago by david

  • Resolution fixed deleted
  • Status changed from closed to reopened

I think I should be able to get the text of the note, no? Also, the sourceitem ID is blank.

These cause problems with where the note is displayed, (in the main list instead of as child of the item the note is being taken on), as well as with sorting.

David

Replying to dstillman:

(In [320]) Fixes #96, When notify() is called for a new note, getNote() on the item returns false

getNote() now returns an empty string rather than false on a new item

David, I assume this is what you meant--if not, reopen

comment:3 Changed 10 years ago by dstillman

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [323]) Fixes #96, When notify() is called for a new note, getNote() on the item returns false

Item.save() changed to not call notify() if a transaction is in progress, which is totally going to trip someone up at some point, and probably me, but it's better than a new parameter

Note: See TracTickets for help on using tickets.