downloadAssociatedFiles pref has no effect if automaticSnapshots is false

[dstillman]

​http://forums.zotero.org/discussion/1450/

[zeppomedio]

Patch to allow for saving attachments without saving snapshots

[zeppomedio]

I took a stab at fixing this problem -- the attaching code path was never getting hit in the case of automaticSnapshots=false. The fix was to add a check for downloadAssociatedFile, with an additional check that if the attachment about to be saved is the site itself and you didn't ask for autoSnapshots, to not save that particular attachment.

[dstillman]

(In [2818]) Fixes #901, downloadAssociatedFiles pref has no effect if automaticSnapshots is false

Cleaner version of zeppomedio's patch, with an additional check to not save links when automaticSnapshots is off (since that code would now be executed even if only downloadAssociatedFiles was checked)

I haven't tested this extensively, but the settings seem to now work as expected. Thanks to zeppomedio for the patch.

[dstillman]

(In [2819]) Addresses #901, downloadAssociatedFiles pref has no effect if automaticSnapshots is false

The URL check wasn't sufficient. On JSTOR, for example, with the snapshot pref disabled and the download pref enabled, it would still return both a snapshot and a PDF, since the snapshot's URL is different from the URL in the URL field. (JSTOR records actually shouldn't have a URL field value at all, but that's #827.) Now saving only if snapshot pref is on or attachment isn't HTML.