Opened 9 years ago

Last modified 6 years ago

#900 new defect

BCE date parsing

Reported by: dstillman Owned by: dstillman
Priority: minor Milestone:
Component: data layer Version: 2.1
Keywords: citeproc-js Cc: erazlogo, simon

Description

Entering "2007 BCE" in a date field currently throws an error

This will need some fixes on the CSL end too, but the error should be fixed ASAP.

Change History (5)

comment:1 Changed 9 years ago by dstillman

  • Cc simon added
  • Milestone changed from 1.0.3 to 1.0.4

strToDate() returns "2007 BCE" (and "2007 BC") in the year property. Probably should return a consistent form such as "-2007", and we can update the other parts of the software to deal with that possibility.

comment:2 Changed 7 years ago by dstillman

(In [4875]) Addresses #900, BCE date parsing

Don't try to save year if not 1-9999

comment:3 Changed 7 years ago by dstillman

Just to clarify my previous commit message, BCE dates can now be entered into date fields and imported from files—it just no longer tries to save them into the SQL-formatted portion of our multipart dates in the database, which is what was causing the error.

comment:4 Changed 6 years ago by fbennett

CSL 1.0/citeproc-js handle negative dates okay now, so there is a home for BC/BCE dates once parsed.

comment:5 Changed 6 years ago by dstillman

  • Keywords citeproc-js added
  • Milestone 1.0.10 deleted
  • Priority changed from major to minor
  • Version changed from 1.0 to 2.1
Note: See TracTickets for help on using tickets.