Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#821 closed defect (fixed)

Validate and correct URLs passed from translators

Reported by: dstillman Owned by: simon
Priority: major Milestone: 1.0.2
Component: ingester Version: 1.0
Keywords: Cc: stakats

Description (last modified by dstillman)

​http://forums.zotero.org/discussion/1577

Change History (4)

comment:1 Changed 9 years ago by dstillman

  • Milestone changed from 1.5 Alpha 1 to 1.0.2
  • Priority changed from minor to major
  • Version changed from 1.5 to 1.0

Also importFromURL() (and/or getFileNameFromURL() and _getExtensionFromURL()):

​http://forums.zotero.org/discussion/1585/trying-to-import-from-endnote/

comment:2 Changed 9 years ago by dstillman

(In [2033]) Addresses #821, Validate URL in linkFromURL() before calling doHead()

Not fixing this in the attachments layer -- even if I corrected URLs in the attachments layer, the translation layer would still revert them to the original. Instead, importFromURL() and linkFromURL() will now just throw an explicit error if passed an invalid URL.

comment:3 Changed 9 years ago by dstillman

  • Cc stakats added
  • Component changed from data layer to ingester
  • Description modified (diff)
  • Owner changed from dstillman to simon
  • Status changed from new to assigned
  • Summary changed from Validate URL in linkFromURL() before calling doHead() to Validate and correct URLs passed from translators

Reassigning to Simon to (possibly) fix in the ingester layer. (We could just leave this problem to the translators, in which case this could be WONTFIXed, but it might more sense to correct them in one place.)

comment:4 Changed 9 years ago by simon

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [2068]) closes #821, Validate and correct URLs passed from translators
closes #760, Files specified in ​file:// URLs should be imported

Note: See TracTickets for help on using tickets.