Opened 9 years ago

Closed 6 years ago

#745 closed enhancement (fixed)

Add Unfiled search condition

Reported by: dstillman Owned by: dstillman
Priority: minor Milestone:
Component: data layer Version: 2.1
Keywords: Cc:

Description


Attachments (1)

orphans.patch (171.5 KB) - added by fbennett 6 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 9 years ago by dstillman

Requested http://forums.zotero.org/discussion/1233/

And probably elsewhere.

comment:2 Changed 6 years ago by fbennett

  • Version changed from 1.5 to 2.1

The problem of unfiled items seems to come around pretty frequently. I'm attaching a patch against Zotero trunk r6299, as "orphans.patch", that layers on top of the duplicates patch that I've floated over on zotero-dev (a copy of the relevant version of that patch is also attached here for reference, and to make it easier to apply the orphans patch).

The orphans patch just offers an additional option "Show orphans" in the context menu of the library and each group to which the user has write access. When invoked, the middle pane shows only orphan items from the library, and the context menu item changes to "Cancel orphan view". There's not much to it, the SQL that fetches the view is in the file orphan.js.

I don't know what other will think of the interface, but checking for unfiled items is something a user is likely to want to do at odd times against random collections. It seems to me that making it permanently available under a context menu is convenient, and keeps clutter out of the collections tree view.

(Bumping the target version for this ticket to 2.1, so that it doesn't fall out of the mix. Let me know if that's not an appropriate thing to do.)

comment:3 Changed 6 years ago by fbennett

This patch will not apply cleanly to revisions above 6299.

This patch depends on duplicates_v06.patch, which is being kept in sync with the current trunk revision, under ticket #1146.

Changed 6 years ago by fbennett

comment:4 Changed 6 years ago by fbennett

Oh, what the heck. Replacing with an updated version of the patch that will apply against r6346, if the patch attached to #1146 is applied first. The updated patch was done without quashing whitespace, because I couldn't get it to apply successfully to the sources with that option turned on.

comment:5 Changed 6 years ago by dstillman

  • Milestone 2.0 Beta 3 deleted

Milestone 2.0 Beta 3 deleted

comment:6 Changed 6 years ago by dstillman

  • Resolution set to fixed
  • Status changed from new to closed

(In [8191]) Closes #745, Add Unfiled search condition

Adds "Show Unfiled Items" context menu to libraries, which adds a virtual saved search for unfiled items. Right-click, Remove to hide. Per-library visibility is saved in prefs and persists across restarts.

Implemented as 'unfiled' search condition, but not accessible via search UI

Should probably use a different color icon to differentiate from real saved searches

Note: See TracTickets for help on using tickets.