Opened 9 years ago

Closed 9 years ago

#700 closed defect (fixed)

Update csledit.xul to use new citation API

Reported by: stakats Owned by: dstillman
Priority: major Milestone: 1.0 RC 1
Component: interface Version: 1.0
Keywords: Cc: simon

Description

Among other things, Simon is now using a new function generateItemSet() instead of preprocessItems(). createBibliography() is basically the same (except that it now requires an itemSet), but createCitation() has changed substantially.

Change History (5)

comment:1 Changed 9 years ago by dstillman

  • Resolution set to fixed
  • Status changed from new to closed

(In [1578]) Closes #700, Update csledit.xul to use new citation API

Think this works. Reopen if problems.

comment:2 Changed 9 years ago by stakats

  • Resolution fixed deleted
  • Status changed from closed to reopened

Looks like citations are displaying HTML tags rather than formatted text. Example:

Brockliss and Jones, <span style="font-style:italic">The Medical World of Early Modern France</span>.

Bibliography formats and displays fine. Maybe I'm doing something wrong?

comment:3 Changed 9 years ago by dstillman

  • Cc simon added

Looks like the new CSL engine is creating HTML entities rather than raw HTML, and I'm not sure how to access the dontEscape flag from the public interface.

Simon, could you take a look at this? To recreate the problem, add <text macro="title" prefix=""/> after </date> in the citation section of the new APA style.

comment:4 Changed 9 years ago by simon

Yup, it's my fault. I'll submit a patch tonight or tomorrow.

comment:5 Changed 9 years ago by simon

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [1579]) - closes #700, Update csledit.xul to use new citation API (I think)

  • closes #640, Improve user-entered text character handling
  • addresses #701, Other CSL issues
  • might add support for <text value="(text)"/> (I haven't tested this)
  • fixes a bug where the document preferences window would appear when adding the second reference after Firefox or the document had been opened and closed (introduced in r1577)
  • fixes a bug in purging deleted citations

again, this has not been tested in OOo or WinWord

Note: See TracTickets for help on using tickets.