Improve user-entered text character handling

[stakats]

Certain characters in the page field kill the plugin (e.g. quotation marks and colons on the Mac) and others are mangled (accented characters).

[mccaskey]

I can't reproduce this on Word 2003 on XP. Which version of the plugin and what platform are you on?

[stakats]

I've tracked down one source of the "An error occurred communicating
with Zotero" problem: quotation marks entered into the "page" field
when adding a citation. For example:

{ ADDIN ZOTERO_ITEM 3813_p"Avertissement"_IQZzih5O }

which appears as

Nicolas Andry, Traité des alimens de caresme (Paris: Jean-Baptiste
Coignard, 1713), "Avertissement."

Entering such a citation works fine, but further attempts to add or
refresh citations will fail.

Perhaps we should escape quotation marks and any other problematic
characters? Any idea about how to handle people's currently "broken"
docs?

[iannz]

Using Word fields I have been unable to reproduce this problem on Word2000 for Windows.

What platform are you using (windows/Mac)?

Which version of Word are you running?

Which version of Zotero are you running (are you using the development builds (​http://dev.zotero.org/svn_and_trac_access#development_xpi)?

Are you using the latest Word Plugin from ​https://www.zotero.org/svn/integration/branches/ice/

However, for bookmarks it is a problem as you can not have quotation marks in a bookmark name (in either Word or OOo). I will look into this (unless someone else does first) but I have some other contracts that I must put time into first (they pay me :-) ).

[stakats]

I cannot reproduce the problem with Word 2000 for Windows, so perhaps the problem is linked to the way the SOAP request is packaged and sent on the Mac? In addition to the above problem with quotation marks, a colon also causes the same failure.

Accented characters are often mangled by the CSL formatting but do not cause RPC failures like quotation marks and colons.

[simon]

(In [1579]) - closes #700, Update csledit.xul to use new citation API (I think)

• closes #640, Improve user-entered text character handling
• addresses #701, Other CSL issues
• might add support for <text value="(text)"/> (I haven't tested this)
• fixes a bug where the document preferences window would appear when adding the second reference after Firefox or the document had been opened and closed (introduced in r1577)
• fixes a bug in purging deleted citations

again, this has not been tested in OOo or WinWord

[stakats]

Accented characters entered into the Page/Paragraph/Line dialog still get mangled on refresh (or when next citation is entered). For example, "Préface" becomes "Préface" (under MacOS or Windows)

Colons and quotation marks no longer kill the connection, but I'm still finding that communication between Word and Zotero seems prone to failure. Removing all citations does not solve the problem. Any ideas what I should be looking for?

[simon]

(In [1580]) addresses #640, Improve user-entered text character handling

This should fix issues with accented characters. Sean, are you having other issues with RPC? Can you reproduce them?

[stakats]

Accented characters now working beautifully.

Have identified a situation which breaks RPC communication:

Click "OK" in add citation dialog without an item selected. An incomplete field code (missing item ID) will be created. When you try to add another citation later, you will get a communication failure message. Clicking the Zotero toolbar refresh button will clean up the bad field code, but it never should get entered in the first place. Suggest graying out "OK" button unless item is selected in dialog.