Opened 9 years ago

Closed 6 years ago

#639 closed enhancement (invalid)

Translators should truncate extraneous query strings

Reported by: dstillman Owned by: mcburton
Priority: minor Milestone:
Component: ingester Version: 1.5
Keywords: helpwanted Cc: stakats, simon

Change History (7)

comment:1 Changed 9 years ago by dstillman

  • Keywords helpwanted added

comment:2 Changed 9 years ago by stakats

I'm not sure how the logic for this feature would work since in some cases we would not want to strip query parameters. I wonder if we might not wind up causing more problems?

comment:3 Changed 9 years ago by dstillman

It's just on a translator-by-translator basis. NYT query strings, for example, can always be stripped (and are in my report generation code).

comment:4 Changed 9 years ago by simon

  • Cc mikowitz added
  • Milestone 1.0 RC 4 deleted

Is this still an issue?

comment:5 Changed 9 years ago by dstillman

  • Cc simon added; mikowitz removed
  • Milestone set to 1.5 Alpha 1
  • Owner changed from simon to mikowitz
  • Status changed from new to assigned
  • Version changed from 1.0 to 1.5

Sure. NYT articles, for example, still have query strings attached. I haven't looked at the query strings from other translators, but I imagine some can be stripped, especially on the news/magazine ones.

comment:6 Changed 6 years ago by dstillman

  • Milestone 2.0 Beta 3 deleted

Milestone 2.0 Beta 3 deleted

comment:7 Changed 6 years ago by ajlyon

  • Resolution set to invalid
  • Status changed from assigned to closed

Closing. This is something that we try to do in translator development already, and it's not a bug, just a general design guideline.

Note: See TracTickets for help on using tickets.