Annotations may only be opened in one window at once

[dstillman]

Annotations and highlights can be lost if the same snapshot is opened in multiple windows/tabs and changes are made to the first one to be closed.

[simon]

Dan, how are you handling issues like this with notes? This probably calls for a similar approach.

[dstillman]

Well, two things. Notes use a save timer, so changes are automatically saved within 1.5 seconds or so (see #636). And then the note editor registers itself with the Notifier so that it receives item-modify notifications and updates itself automatically.

So, this is blocked by #666 (which depends on #665). Once that's done, I think browser.js could just register a callback with the Notifier when a snapshot is loaded and refresh on an item modification (and clear all annotations on a delete event, I guess). Even if we had more granular notification events, doing it on the page probably makes more sense than registering a callback for each annotation box.

[simon]

(In [1586]) addresses #637, Annotations can be lost if a snapshot is opened in multiple places. since notifier support will not be ready in time, this patch presents a warning when two copies of the same snapshot are opened, and does not enable annotation on the second.

[simon]

Now major, not critical

[dstillman]

Milestone 2.0 Beta 3 deleted