Don't iterate Array with for...in

[dstillman]

For better compatibility with extensions that extend Array.prototype, don't use for...in to iterate arrays. Can't do anything about extensions that extend Object.prototype, though.

[dstillman]

(In [1347]) Addresses #597, Don't iterate Array with for...in

[dstillman]

(In [1348]) Addresses #597, Don't iterate Array with for...in

[dstillman]

(In [1372]) Fixes #598, Renaming selected tag causes library to "disappear"
Addresses #597, Don't iterate Array with for...in

[dstillman]

(In [1419]) Fixes #621, saved search displays child items in black even if only parent item matches search criteria
Addresses #597, Don't iterate Array with for...in

Also fixes child items displaying twice in saved search reports and adds proper collation support in reports

[dstillman]

So I've just done some more testing here, and it looks like we should at least be careful about this in window code. The XPCOM object is insulated from this problem, but our own window scope code is not, and so an extension that bundled Prototype or otherwise extended Array.prototype could cause nasty problems in subtle ways.

So, we could probably continue to use for...in in xpcom code with impunity, but in all other code we should take care to use a standard for (var i=0; i<max; i++) loop and fix any remaining for...in loops over arrays.

[dstillman]

We should still try not to use "for ... in" in window code, but this hasn't been an issue in a long time, so we've either fixed all of these or other extensions have stopped extending Array.prototype.

[simon]

We need to avoid for...in in all connector-related code, since pages can extend Array.prototype.

[simon]

In [10403]:

Addresses #597, Don't iterate Array with for...in

[ajlyon]

Is this something that affects translators as well, or just core code?

[simon]

This affects some translators as well. The translator framework and translators that scrape pages that extend Array.prototype will eventually need to be modified not to iterate over arrays with for...in. However, most sites don't do this, so most translators should be fine.

[ajlyon]

So the sandbox protects translators from extensions that extend Array.prototype, correct?

If it's entirely a case of just watching out for sites that extend Array.prototype, then I'll just try to keep this in mind as a potential gotcha in future development and troubleshooting and do nothing at the moment.

[simon]

In [10405]:

Addresses #597, Don't iterate Array with for...in