Opened 10 years ago

Closed 10 years ago

#534 closed defect (fixed)

Export fails on missing attachments

Reported by: dstillman Owned by: simon
Priority: major Milestone: 1.0 Beta 4
Component: export Version: 1.0
Keywords: Cc:

Description

attachment.getFile() in Translate._exportGetAttachment() can return false if a file is missing, but this shouldn't cause the export to fail as it's doing now:

Translation using Zotero RDF failed: 
message => file.copyTo is not a function
fileName => chrome://zotero/content/xpcom/translate.js
lineNumber => 1784
stack => ([object Object])@chrome://zotero/content/xpcom/translate.js:1784
()@chrome://zotero/content/xpcom/translate.js:1806
()@chrome://zotero/content/xpcom/translate.js:664
doExport()@chrome://zotero/content/xpcom/translate.js:905
()@chrome://zotero/content/xpcom/translate.js:1686
()@chrome://zotero/content/xpcom/translate.js:580
(0)@chrome://zotero/content/fileInterface.js:84
@:0

It should probably just skip saving the file but still add the entry to the RDF file, such that importing the RDF again results in an attachment with a missing file. (There'll eventually be a way to relink missing attachments, so this will be important.)

Change History (2)

comment:1 Changed 10 years ago by dstillman

  • Summary changed from Export files on missing attachments to Export fails on missing attachments

comment:2 Changed 10 years ago by simon

  • Resolution set to fixed
  • Status changed from new to closed

(In [1232]) closes #530, add base field conversion to translation level
closes #534, export fails on missing attachments

Note: See TracTickets for help on using tickets.