Amazon URLs should be saved as attached links instead of URL field

[dstillman]

And the accessDate should be on the link, not the main item

[stakats]

Turns out we don't actually have this functionality from translators. Handing back to Simon.

[simon]

This functionality is disabled (see #327). It's still in the code, just commented out. Should I re-enable it?

[simon]

If the answer is yes, should we save URLs we would snapshot as links when the take snapshots pref is disabled (which was the previous behavior)?

[dstillman]

Yes to re-enable. (Storing things like Amazon URLs in the URL field causes all items saved from Amazon to have a Retrieved From line, which we obviously don't want.)

The answer to your second question depends partly on whether the URL of the snapshot page is also stored in the URL field. When it is (as on NYT, for example), there's no need to save snapshots as links with the pref off. When it's not (are there any such cases?), linking instead might make sense. However, I'm guessing most users just think of the pref as, "Don't attach this annoying thing every time. I can look it up again on Amazon if I need to." In which case, links and snapshots should just both be dependent on the pref...

[simon]

(In [1255]) closes #525, Amazon URLs should be saved as attached links instead of URL field

setting the snapshot property on an attachment explicitly to false now forces a link, rather than a snapshot, to be generated