Arrow on full-screen button should point the other way when in full-screen mode

[dstillman]

From ​http://groups.google.com/group/zotero-dev/browse_thread/thread/b2ab8c9aea8fc971

[rmzelle]

I think I got an easy fix for this ticket. I got it working in my local 1.5SP3.6 copy, but, as I'm rather a novice in this territory, it's probably a good idea to check the fix to see if it doesn't break other stuff.

In the current trunk, there seem to be two attributes that are used to indicate whether full-screen mode is toggled on or off: zotero-tb-fullscreen.zoterotop and zotero-tb-fullscreen.fullscreenmode*. The former attribute is specified only once in all the Zotero code in overlay.js, but that line doesn't result in the desired behavior (hence the ticket). The latter attribute is used to add a shadow to the full-screen button when in full-screen mode. As this shadowing does work, all I did was group the css-line that specifies the use of the down-arrow button with the lines specifying the shadow, making it dependent on the fullscreenmode-attribute. I also removed the line that set the value of zotero-tb-fullscreen.zoterotop, as after this change it isn't read anywhere anymore anyway.

• https://www.zotero.org/trac/browser/extension/trunk/chrome/skin/default/zotero/overlay.css?rev=4041#L232

https://www.zotero.org/trac/browser/extension/trunk/chrome/content/zotero/overlay.js?rev=4041#L132

[dstillman]

(In [4880]) Closes #522, Arrow on full-screen button should point the other way when in full-screen mode