Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#47 closed enhancement (fixed)

Advanced search window

Reported by: dcohen Owned by: dstillman
Priority: major Milestone: 1.0 Beta 4
Component: interface Version: 1.0
Keywords: Cc:

Description (last modified by dstillman)

Advanced search without going through saved search

Search dialog with conditions at top, results pane (treeview) on buttom. Double-clicking item takes you to the item in the opener. If the opener no longer exists...new browser window, open Zotero pane and select item.

Change History (13)

comment:1 Changed 10 years ago by dstillman

Depends on #7

comment:2 Changed 10 years ago by david

  • Owner changed from dnorton to david

comment:3 Changed 10 years ago by david

  • Milestone changed from 1.0 Alpha 2 to 1.0 Beta 1

comment:4 Changed 10 years ago by david

  • Resolution set to fixed
  • Status changed from new to closed

(In [444]) Closes #47, advanced search
Closes #152, Saved Searches (interface layer)

For now, advanced search IS a saved search.

There are still bugs. The 'search' icon is ugly. I wanted to get it out there, however.

comment:5 Changed 10 years ago by dstillman

  • Milestone changed from 1.0 Beta 1 to 1.0 Beta 2
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for separate window search

comment:6 Changed 10 years ago by dstillman

  • Owner changed from david to dstillman
  • Status changed from reopened to new

comment:7 Changed 10 years ago by dstillman

  • Description modified (diff)

comment:8 Changed 10 years ago by dstillman

  • Milestone changed from 1.0 Beta 2 to 1.0 Final

comment:9 Changed 10 years ago by dstillman

  • Milestone changed from 1.0 Final to 1.0 Beta 3

comment:10 Changed 10 years ago by dstillman

  • Summary changed from advanced search to Advanced search window

comment:11 Changed 10 years ago by dstillman

  • Milestone changed from 1.0 Beta 3 to 1.0 Beta 4

comment:12 Changed 10 years ago by dstillman

  • Resolution set to fixed
  • Status changed from new to closed

(In [1116]) Closes #47, Advanced search window

And they said it would never happen.

Doesn't yet support dragging items to other windows, etc., but you can double-click to focus the item in the most recent Zotero pane. You can also save the search as...a saved search, which means that theoretically we could get rid of the now-redundant "New Saved Search" icon.

Other/related changes

Search dialog:

  • Better keyboard handling (focus condition menu by default, Enter to trigger command (e.g. search in the Advanced Search window), Shift-Enter to add new row)

Zotero.Search:

  • Zotero.Search.clone() -- return copy of search
  • Zotero.Search.getSearchConditions() now returns copy of conditions

itemTreeView:

  • Always sort by the first column if no sort column set; removed isSorted() logic, since isSorted() now always returns true
  • Made itemsTreeView.refresh() call rowCountChanged, since there were cases in which the tree could end up looking for nonexistent rows after they'd been removed
  • selectItem() now takes a second parameter, expand, to open the selected item if it's a container
  • selectItem() now tries to get the selected item at least slightly away from the bottom (since ensureRowIsVisible does only the bare minimum) and also tries to get the parent item in view when scrolling upwards to make a child item visible
  • Moved getSelectedItems() logic into the treeview instead of overlay.js

comment:13 Changed 10 years ago by dstillman

(In [1117]) Addresses #47, Advanced search window

Missed file

Note: See TracTickets for help on using tickets.