Opened 10 years ago
Closed 10 years ago
#257 closed defect (fixed)
snapshots not getting the CSS from some web pages
| Reported by: | dcohen | Owned by: | dstillman |
|---|---|---|---|
| Priority: | major | Milestone: | |
| Component: | data layer | Version: | future |
| Keywords: | helpwanted | Cc: |
Description
Change History (8)
comment:1 Changed 10 years ago by simon
- Component changed from ingester to data layer
- Owner changed from simon to dstillman
comment:2 Changed 10 years ago by dstillman
- Milestone changed from 1.0 Beta 1 to 1.0 Beta 2
Yeah, I know about this. Won't get fixed for Beta 1, but it should be fixable for Beta 2 with much pain and misery.
Unless Mozilla fixes it first... I'll check Bugzilla.
comment:3 Changed 10 years ago by simon
comment:4 Changed 10 years ago by dstillman
- Milestone changed from 1.0 Beta 2 to 1.0 Final
comment:5 Changed 10 years ago by dstillman
- Type changed from enhancement to defect
comment:6 Changed 10 years ago by dstillman
- Keywords helpwanted added
Other extensions (e.g. Scrapbook) get around this by basically reimplementing nsIWebPagePersist, which I really rather not do.
As I mentioned on the mailing list, one ugly hack would be to search the persisted page for @import files and manually grab them, updating the original page with relative <link/> elements. Pretty bad, but probably not worse than reimplementing all of nsIWBP...
comment:7 Changed 10 years ago by dstillman
- Milestone 1.0 Final deleted
- Version changed from 1.0 to future
comment:8 Changed 10 years ago by dstillman
- Resolution set to fixed
- Status changed from new to closed
(In [1236]) Fixes #257, snapshots not getting the CSS from some web pages
Switched importFromURL() from native Mozilla saveDocument() to WebPageDump code (originally from Scrapbook), which fixes CSS saving problems and other issues -- viewing a WPD snapshot of the New York Times front page causes a crash in the Flash plugin in all Mac browsers, however, unless the Flash security settings are changed to whitelist the Zotero storage directory for accessing the network (but this should be done anyway, since the warning is annoying)
Also:
- Fix broken items list in Related and Advanced Search windows from r1231
- Fix several _getItemAtRow() errors from r1231
- Adjusted Zotero.Progress API: fade()->startCloseTimer(), kill()->close()
- Added forceTitle parameter to importFromURL(), currently unimplemented -- note that order of the last parameter changed
- Added progress windows for "Create New Item from Current Page", snapshot, and link actions
- Added "Miscellaneous" caption in General pane of preferences
- Clarify Mac rich-text warnings
- Switched small Export prefpane to generic icon
yeah, it's about @import vs <link>. if you changed <style type="text/css" media="screen">@import "index.css";</style> to <link rel="stylesheet" type="text/css" href="index.css" /> it would work. this is really an issue with nsIWebBrowserPersist, which Dan is using to save the pages, although it should be possible to work around.