#190 closed defect (fixed)
tag issues
| Reported by: | simon | Owned by: | david |
|---|---|---|---|
| Priority: | critical | Milestone: | 1.0 Beta 1 |
| Component: | interface | Version: | 1.0 |
| Keywords: | Cc: |
Description
when i first click the Tags tab on an item, nothing appears. as soon as i click to another item with the Tags tab still selected, the tags on that item appear. if i then click back to the item I was looking at before, I can see the tags, but this should work the first time.
Change History (3)
comment:1 Changed 10 years ago by simon
- Priority changed from major to critical
comment:2 Changed 10 years ago by david
- Resolution set to fixed
- Status changed from new to closed
comment:3 Changed 10 years ago by dstillman
(In [522]) OK, I think this should fix both #179 ("adding a new creator then clicking an existing creator makes the creator field disappear") and #190 ("tag issues") -- I caused #190 with my fix to the former, and David rebroke #179 with his revert to fix the latter.
The problem was twofold: 1) onselect="ScholarItemPane.loadPane(this.selectedIndex)" is (for some reason) triggered when clicking off of the "+" creator add button onto the rest of the deck pane (and not just when switching tabs) and 2) the selectedIndex passed into loadPane() from the deck during the non-tab triggers is (for some reason) an empty string rather than the index of the selected tab, which is why the creator problem only used to happen the first time you clicked away from a "+" (before the empty string was stored as a key in the _loaded array). (In short, onselect for decks is pretty broken.)
Now only calling loadPane if (this.selectedIndex!==) -- can't just test for typeof=='number' because this.selectedIndex on the deck is always a string
upgrading to critical; this happens every time i click any of the attachments/notes/tags/related tabs for the first time