Opened 5 years ago

Closed 5 years ago

#1876 closed defect (fixed)

PATCH: MODS does not have <detail><text/></detail>

Reported by: karnesky Owned by: ajlyon
Priority: minor Milestone:
Component: translators Version: 1.0
Keywords: Cc:

Description

The MODS schema only allows "title", "caption", or "number" to be branched from the detail node. There is no reason to do an integer check for volume/issue/series.

This allows roman numeral volume numbers to work.

There may be some sources that store a part's TITLE in the field instead of a volume number. I don't think that it is very common & it seems better to emit valid MODS XML.

Attachments (1)

MODS.js.diff​ (1.3 KB) - added by karnesky 5 years ago.

Download all attachments as: .zip

Change History (2)

Changed 5 years ago by karnesky

comment:1 Changed 5 years ago by ajlyon

  • Resolution set to fixed
  • Status changed from new to closed

Applied in ​https://github.com/zotero/translators/commit/a4d9e88d2e7570d1676db17df3f7ec27eb249036

In the future, it'd be easier to submit translator patches as pull requests, since the primary code repository for translators is now on Github.

Note: See TracTickets for help on using tickets.