Opened 5 years ago

Closed 5 years ago

#1860 closed defect (fixed)

Scaffold can't safely test collection creation

Reported by: ajlyon Owned by: simon
Priority: major Milestone:
Component: scaffold Version: 2.1
Keywords: Cc:

Description

Collections created by translators run in Scaffold produce real collections in the user's local library. This is a major problem for import translators, and it might affect the translator testing infrastructure when used for import translators as well.

We currently prevent item saving by calling translate(false) -- is there a reason that this doesn't prevent collection saving?

Collection support may also need a onCollectionDone callback, to provide feedback on the created collections, and to build test fixtures.

Change History (1)

comment:1 Changed 5 years ago by simon

  • Resolution set to fixed
  • Status changed from new to closed

In [9802]:

Closes #1860, Scaffold can't safely test collection creation

Zotero.Translate#translate(false) should no longer create collections. There was already a collectionDone event; it now gets the unprocessed collection object when false is passed to Zotero.Translate#translate.

Note: See TracTickets for help on using tickets.