Opened 5 years ago

Closed 5 years ago

#1852 closed defect (fixed)

Test success may depend on capitalizeTitles preference

Reported by: ajlyon Owned by: ajlyon
Priority: major Milestone:
Component: translators Version: 2.1
Keywords: Cc: simon

Description

The Voyager translator test fails for me, because the test was created with capitalizeTitles set to true, and I have it set to false.

17:36:44 TranslatorTester: Running 1  test for Library Catalog (Voyager)
17:36:51 COMPAT WARNING: No callback was provided for Zotero.selectItems(). When executed outside of Firefox, a selectItems() call will require that this translator to be called multiple times.
17:36:52 Translation successful
17:36:52 Param title differs: {"x":"Zotero: A Guide for Librarians, Researchers, and Educators","y":"Zotero: a guide for librarians, researchers, and educators"}

Could we make the translator testing framework temporarily override the preference setting to guarantee that it works identically for everyone? Or should we ignore case when making these comparisons?

I'm a little hesitant to do the latter, since case changes can in fact be a problem at times, and it'd be good to detect them.

Change History (2)

comment:1 Changed 5 years ago by dstillman

I think overriding to false would make sense.

comment:2 Changed 5 years ago by simon

  • Resolution set to fixed
  • Status changed from new to closed

In [9758]:

Closes #1852: Test success may depend on capitalizeTitles preference

Note: See TracTickets for help on using tickets.