Opened 6 years ago

Closed 6 years ago

#1807 closed defect (worksforme)

citationItem.uri handled as String, not Array in integration.js

Reported by: fbennett Owned by: simon
Priority: major Milestone:
Component: word integration Version: 2.1
Keywords: Cc: fbennett

Description (last modified by fbennett)

While updating integration.js to conform to the trunk, I came across the attached patch that I applied a couple of weeks ago.

I think that citationsItems.uri is delivered as an array. If that's right, checking for its presence should require citationItems.uri.length.

(The objectStr condition block in the patch can be cut out for main; it's used with a companion patch to identify itemID mappings set by the duplicates merge machinery.)

Attachments (1)

Diff-int-18.patch​ (744 bytes) - added by fbennett 6 years ago.

Download all attachments as: .zip

Change History (5)

Changed 6 years ago by fbennett

comment:1 Changed 6 years ago by fbennett

  • Description modified (diff)

comment:2 Changed 6 years ago by simon

Frank, can you clarify why this is necessary? At least as far as I am aware, if there is a URI field embedded in a document, it should never be empty.

comment:3 Changed 6 years ago by fbennett

Unfounded paranoia on my part; I thought the field might be a dummy container, possibly empty. Feel free to close this, sorry for the distraction.

comment:4 Changed 6 years ago by simon

  • Resolution set to worksforme
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.