Apparent duplication of standalone attachment after drag

[simon]

Expanding an item and then dragging a standalone attachment over the item results in apparent duplication of the standalone attachment. The DB is fine, as can be verified by opening a new window, so this seems to be primarily a UI issue. I will look into this further to see if I can narrow down potential causes.

[simon]

I can reproduce in 2.0.9, so this doesn't seem to be new. Downgrading priority, since no one has complained thus far, but we should still fix this.

[dstillman]

I can't reproduce this.

[simon]

I can reproduce this on both Mac and Windows in new profiles, but I now realize that it will only happen when the attachment being dragged is higher in the item tree than the item it is being dragged upon. Here's a better STR:

1. Sort the item list by Date Added descending
2. Create a new item
3. Attach a note or attachment to the item
4. Expand the item so that the children are visible (it doesn't happen without this)
5. Create a standalone note or attachment
6. Drag the standalone note or attachment over the item

[simon]

A post on the forums: ​http://forums.zotero.org/discussion/17055/ui-bug-attachments-stay-stuck-outside-a-reference-after-dragging-inside/

[dstillman]

In [9340]:

Fixes #1798, Apparent duplication of standalone attachment after drag

Trigger change notification for moved item before new parent item so that the tree view can detect that the moved item is in the wrong place, remove it, and then refresh the new parent item's children