#1796 closed defect (fixed)
trigger() checks type rather than event for 'modify', 'delete'
| Reported by: | fbennett | Owned by: | dstillman |
|---|---|---|---|
| Priority: | trivial | Milestone: | |
| Component: | interface | Version: | 2.1 |
| Keywords: | Cc: |
Description
While sorting out a UI issue in the multilingual branch related to notifier events, I noticed that the trigger() function in notifier.js checks the type argument for the strings 'modify' and 'delete', and issues a warning if the extraData argument is not also supplied with these.
A debugging trace, and the content of the _types array, showed that these strings appear on the event argument, but not on type.
I'm not sure if it's important at all, but the attached patch causes the function to check the event argument instead.
Attachments (1)
Change History (3)
Changed 6 years ago by fbennett
comment:1 Changed 5 years ago by dstillman
- Resolution set to fixed
- Status changed from new to closed
comment:2 Changed 5 years ago by dstillman
In [10639]:
Note: See
TracTickets for help on using
tickets.
In [10609]: