Opened 6 years ago

Closed 6 years ago

#1745 closed defect (fixed)

Observe private browsing mode

Reported by: ajlyon Owned by: dstillman
Priority: major Milestone:
Component: translators Version: 2.1
Keywords: Cc:

Description

Mozilla policy on add-ons requires that they observe private browsing mode [1,2].

As I understand it, saving items needn't observe the mode, but our error reporting should; we shouldn't ping ​http://www.zotero.org/repo/report when translators fail if we are in private browsing mode. The attached patch against trunk adds the recommended boilerplate for checking for PB mode.

I'm marking this as a defect, since technically Zotero shouldn't be allowed in addons.mozilla.org unless it observes PB mode correctly.

  1. ​http://ehsanakhgari.org/blog/2010-02-17/private-browsing-support-firefox-extensions
  2. ​https://developer.mozilla.org/En/Supporting_private_browsing_mode

Attachments (1)

translate.js.diff​ (1.3 KB) - added by ajlyon 6 years ago.
Patch for PB observance in translator error reporting

Download all attachments as: .zip

Change History (3)

Changed 6 years ago by ajlyon

Patch for PB observance in translator error reporting

comment:1 Changed 6 years ago by dstillman

  • Owner changed from mcburton to dstillman
  • Status changed from new to assigned

comment:2 Changed 6 years ago by dstillman

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [7271]) Fixes #1745, Observe private browsing mode

Don't report translator failure if in private browsing mode

Thanks to ajlyon for the patch

Note: See TracTickets for help on using tickets.