Opened 6 years ago

Closed 6 years ago

#1736 closed defect (invalid)

rtfScan breaks due bad citeproc-js return value

Reported by: fbennett Owned by: simon
Priority: major Milestone:
Component: word integration Version: 2.1
Keywords: Cc:

Description

The appendCitationCluster() method in citeproc-js was not adjusted when the return value of processCitationCluster() (on which it depends) was changed at version 1.0.51. This has been fixed in the new 1.0.63 release of citeproc-js, and with that version and this patch, the rtfScan feature should begin working again.

Attachments (1)

rtfscan.patch​ (586 bytes) - added by fbennett 6 years ago.

Download all attachments as: .zip

Change History (3)

Changed 6 years ago by fbennett

comment:1 Changed 6 years ago by fbennett

I missed out the actual changes in the 1.0.63 tag. The correct processor version level that goes with this patch is 1.0.64, just checked in.

comment:2 Changed 6 years ago by fbennett

  • Resolution set to invalid
  • Status changed from new to closed

I made bad assumptions about the processor API; the original Zotero code for calling appendCitationCluster() was correct, the breakage in rtfScan was caused exclusively by a bad return value from the citeproc-js function. No change to Zotero required, marking this as "invalid".

Note: See TracTickets for help on using tickets.