Opened 6 years ago
Closed 6 years ago
#1709 closed enhancement (fixed)
[patch] citeproc-js 1.0.51 compatibility patch: makeBibliography() return value
| Reported by: | fbennett | Owned by: | simon |
|---|---|---|---|
| Priority: | major | Milestone: | |
| Component: | word integration | Version: | 2.1 |
| Keywords: | Cc: |
Description
After some waffling, I have decided it makes sense for the makeBibliography() command to simply return false when no cs:bibliography node is available in the style.
This will break the current trunk code. The attached patch fixes things up, and should be safe to apply before the updated processor is merged. If the change in the return value is undesirable, I'm open to suggestions. Documentation on the behavior of the current tip of citeproc-js is in the manual online:
http://gsl-nagoya-u.net/http/pub/citeproc-doc.html#handling-items-with-no-rendered-form
Attachments (1)
Change History (5)
Changed 6 years ago by fbennett
comment:1 Changed 6 years ago by fbennett
- Component changed from uncategorized to word integration
- Owner changed from dstillman to simon
- Version changed from 1.0 to 2.1
comment:2 Changed 6 years ago by fbennett
- Summary changed from Change in return of makeBibliography() when no cs:bibliography node to [patch] citeproc-js compatibility patch (makeBibliography() return value)
comment:3 Changed 6 years ago by fbennett
- Summary changed from [patch] citeproc-js compatibility patch (makeBibliography() return value) to [patch] citeproc-js 1.0.51 compatibility patch: makeBibliography() return value
comment:4 Changed 6 years ago by simon
- Resolution set to fixed
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
(In [6393]) update to citeproc-js 1.0.52
closes #1709: [patch] citeproc-js 1.0.51 compatibility patch: makeBibliography() return value
closes #1712: [patch] citeproc-js 1.0.52 compatibility patch
From Frank's notes for 1.0.52:
In this release, the following change may require accomodation
within the calling application:
Also in this release:
From Frank's notes for 1.0.51:
The API return value changes slightly with this version:
Also in this release: