Items added in multiple mode not recognized unless visible

[fbennett]

While testing 2.1 with a citation containing a large number of same-author, same-year cites (55), I found that the Accept button would not catch fire unless the right-side list of selected items was scrolled down to make the inserted item visible. Apparently there is some sort of just-in-time relationship in XUL between data updates and visibility.

Forcing a scroll to the bottom of the list on insert would probably be enough to avoid the glitch, although I'm not sure how that's done in XUL.

[fbennett]

It turned out to be extremely simple. Patch attached.

[simon]

I'm having trouble reproducing this issue. If I am understanding things right, creating a new citation and selecting references and clicking the green right arrow until the list on the right has more items than it can show without scrolling should result in the "OK" button becoming grayed out, but I can't get this to happen. What platform and what version of Firefox are you running?

[fbennett]

The system is;

Firefox 3.6.4
Ubuntu Jaunty
Zotero 2.1a1r6168
OpenOffice 3.0
OO Integration 3.0a8 (i think).

The OK button doesn't grey out, but clicking on it will not insert the citation until the list is scrolled down to make the freshly inserted item visible. Before it is revealed, clicking on it produces a "Trying to accept" note in the log, with no error and no action.

[simon]

(In [6170]) fixes #1668, Items added in multiple mode not recognized unless visible (twice)
fix Accept button issue by using getAttribute() rather than id property, but also scroll to newly inserted citation, since it's probably the desirable behavior