Opened 8 years ago

Closed 7 years ago

#1306 closed defect (fixed)

Test and deploy snapshot annotation patch

Reported by: tjowens Owned by: simon
Priority: major Milestone:
Component: annotations Version: 1.0
Keywords: Cc:

Description

See fbennett's patch here ​http://forums.zotero.org/discussion/5336

Attachments (1)

17-highlighting.patch​ (2.4 KB) - added by fbennett 7 years ago.
Patch fixing highlighting for snapshots containing tables and BR tags

Download all attachments as: .zip

Change History (3)

Changed 7 years ago by fbennett

Patch fixing highlighting for snapshots containing tables and BR tags

comment:1 Changed 7 years ago by fbennett

  • Type changed from enhancement to defect

A post to the forum -- and the fact that this patch still applies cleanly to the sources -- reminds me that highlighting is still broken in current Zotero. This patch will fix it.

The current code gets navigation across the nodes wrong in some cases, and weird things happen with BR tags. Things apparently break with tables as well, according to the forum report. With this patch, it's rock solid. Please apply and try and, hopefully, "buy".

comment:2 Changed 7 years ago by dstillman

  • Resolution set to fixed
  • Status changed from new to closed

(In [4871]) Closes #1306, Test and deploy snapshot annotation patch

Thanks to Frank for the patch

Note: See TracTickets for help on using tickets.