Opened 8 years ago

Closed 8 years ago

#1157 closed defect (fixed)

Adding an existing tag to an item with no tags breaks Zotero

Reported by: simon Owned by: dstillman
Priority: blocker Milestone: 1.5 Sync Preview 2
Component: data layer Version: 1.5
Keywords: Cc:

Description (last modified by simon)


Change History (4)

comment:1 Changed 8 years ago by simon

  • Component changed from styles to data layer
  • Owner changed from simon to dstillman
  • Status changed from new to assigned

Only happens with some items, e.g. ​this one. The transaction seems to be left open because of an error in item.js involving tags:

message => itemTags.indexOf is not a function
fileName => chrome://zotero/content/xpcom/data/item.js
lineNumber => 2670
stack => ("LTP, Hippocampus, Spatio-temporal stimuli, Learning rule, Optical recording","0")@chrome://zotero/content/xpcom/data/item.js:2670
([object Array],"0")@chrome://zotero/content/xpcom/data/item.js:2713
([object Object])@chrome://zotero/content/xpcom/translate.js:1447
()@chrome://zotero/content/xpcom/translate.js:661
completeItem([object Object])@chrome://zotero/content/xpcom/translate.js:799
doImport()@chrome://zotero/content/xpcom/translate.js:853
()@chrome://zotero/content/xpcom/translate.js:1584
()@chrome://zotero/content/xpcom/translate.js:1573
()@chrome://zotero/content/xpcom/translate.js:1546
()@chrome://zotero/content/xpcom/translate.js:582
([object XPCWrappedNative_NoHelper],null,0)@chrome://zotero/content/xpcom/ingester.js:631

comment:2 Changed 8 years ago by simon

  • Type changed from enhancement to defect

This also seems to have permanently broken my sync. Any attempt now results in an item conflict. When I accept the default resolution, I get the error:

zotero(1): [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [mozIStorageStatement.execute]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://zotero/content/xpcom/db.js :: anonymous :: line 123"  data: no] [QUERY: INSERT INTO items (itemID, itemTypeID, key, dateAdded, dateModified) VALUES (?, ?, ?, ?, ?)] [ERROR: constraint failed]

comment:3 Changed 8 years ago by simon

  • Description modified (diff)
  • Summary changed from Saving items with ScienceDirect translator breaks Zotero to Adding an existing tag to an item with no tags breaks Zotero

comment:4 Changed 8 years ago by dstillman

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [3317]) Fixes #1157, Adding an existing tag to an item with no tags breaks Zotero

Note: See TracTickets for help on using tickets.