Ticket #1770: citations-undefined.patch

chrome/content/zotero/xpcom/integration.js

@@ -1371 +1371 @@
                         citation.citationID = Zotero.randomString();
                 }
                 this.newIndices[index] = true;
-                this.updateIndices[index] = true;
+                // Adding a citation, so newIndices flag does the trick.
+                // Flagging in updateIndices as well causes processor crash.
+                //this.updateIndices[index] = true;
         }
         Zotero.debug("Zotero.Integration: adding citationID "+citation.citationID);
         this.citationIDs[citation.citationID] = true;
@@ -1544 +1546 @@
         if(regenerateAll || this.regenerateAll) {
                 // update all indices
                 for(var i=0; i<this.citationsByIndex.length; i++) {
-                        this.newIndices[i] = true;
                         this.updateIndices[i] = true;
+                        if (this.newIndices[i]) {
+                                delete this.newIndices[i];
+                        }
                 }
         } else {
                 // update only item IDs
@@ -1665 +1669 @@
  */
 Zotero.Integration.Session.prototype.restoreProcessorState = function() {
         var citations = [];
-        for(var i in this.citationsByIndex.length) {
-                if(this.citationsByIndex[i] && !this.newIndices[i] && !this.citationsByIndex[i].properties.delete) {
+        for(var i in this.citationsByIndex) {
+                if(this.citationsByIndex[i] && !this.citationsByIndex[i].properties.delete) {
                         citations.push(this.citationsByIndex[i]);
                 }
         }