Ticket #1262: zs15_fbennett_2008-12-18-3.patch

content/zotero/xpcom/csl.js

@@ -20 +20 @@
     ***** END LICENSE BLOCK *****
 */
 
+ /*
+ * PATCHES: fbennett
+ *
+ * This patch incorporates the following modification:
+ *
+ * (3) New is-quoted test:
+ *       This test returns true if the target field is enclosed in
+ *     double-quote marks.  This opens a path for the exceptional 
+ *     handling of fields which normally contain a single word or 
+ *     number, and take (the edition field is the obvious example).
+ *     Some such facility will be needed for hands-free processing 
+ *     of the Bluebook style.
+ *
+ *     The changes labled fbennett (3) below provide this test.
+ */
+
 /*
  * CSL: a class for creating bibliographies from CSL files
  * this is abstracted as a separate class for the benefit of anyone who doesn't
@@ -99 +115 @@
 Zotero.CSL._firstNameRegexp = /^[^\s]*/;
 Zotero.CSL._textCharRegexp = /[a-zA-Z0-9]/;
 Zotero.CSL._numberRegexp = /\d+/;
+/*
+ * fbennett (3): adding regexp for detecting enclosing quotes
+ */
+Zotero.CSL._quotedRegexp = /^(".*")$/;
+/* 
+ * fbennett: end
+ */
 Zotero.CSL.prototype.formatCitation = function(citation, format) {
         default xml namespace = "http://purl.org/net/xbiblio/csl"; with({});
         
@@ -757 +780 @@
                                         
                                         if(variables[j] == "locator") {
                                                 // special case for locator
-                                                var text = citationItem && citationItem.locator ? citationItem.locator : "";
+/*
+ * fbennett (3): strip quotes from locator:
+ */
+                                                var text = citationItem && citationItem.locator ? item.stripQuotes(citationItem.locator) : "";
+/*
+ * fbennett: end
+ */
                                         } else if(citationItem && citationItem._csl && citationItem._csl[variables[j]]) {
                                                 // override if requested
                                                 var text = citationItem._csl[variables[j]];
@@ -1036 +1065 @@
                                         
                                         // inspect variables
                                         var done = false;
-                                        var attributes = ["variable", "is-date", "is-numeric", "is-plural", "type", "disambiguate", "locator", "position"];
+/*
+ * fbennett (3): add "is-quoted" to attributes list
+ */
+                                        var attributes = ["variable","is-date", "is-numeric", "is-plural", "type", "disambiguate","locator","position","is-quoted"];
+/*
+ * fbennett: end
+ */
                                         for(var k=0; !done && k<attributes.length; k++) {
                                                 var attribute = attributes[k];
                                                 
@@ -1087 +1122 @@
                                                                         exists = citationItem && citationItem.locator &&
                                                                                 (citationItem.locatorType == variables[j]
                                                                                 || (!citationItem.locatorType && variables[j] == "page"));
+/*
+ * fbennett (3): adding is-quoted condition
+ */
+                                                                } else if (attribute == "is-quoted") {
+                                                                    //special handling for locator
+                                                                    if(variables[j] == "locator") {
+                                                                        exists = citationItem && citationItem.locator ? citationItem.locator.match(Zotero.CSL._quotedRegexp) : ""
+                                                                    } else {
+                                                                        exists = item.getVariable(variables[j],"nostrip").match(Zotero.CSL._quotedRegexp);
+                                                                    }
+/*
+ * fbennett: end
+ */
                                                                 } else {        // attribute == "position"
                                                                         if(variables[j] == "first") {
                                                                                 exists = !citationItem
@@ -1824 +1872 @@
         
         for each(var zoteroField in zoteroFields) {
                 var value = this.zoteroItem.getField(zoteroField, false, true);
-                if(value != "") return value + '';
+/*
+ * fbennett (3): strip quotes from field if form != "nostrip"
+ */
+                if(value != "") return this.stripQuotes(value, form) + '';
+/*
+ * fbennett: end
+ */
         }
         
         return "";
@@ -2062 +2116 @@
 }
 
 /*
+ * fbennett: (3): add function to strip double-quotation marks from a string
+ */
+ Zotero.CSL.Item.prototype.stripQuotes = function(value,form) {
+     if(typeof(value) == "string" && value.substr(0,1) == '"' && value.substr(value.length-1,1) == '"' && form != "nostrip") {
+        return value.slice(1,value.length-1);
+    } else {
+        return value;
+    }
+}
+/*
+ * fbennett: end
+ */
+
+/*
  * Date class
  */
 Zotero.CSL.Item.Date = function(date, sort) {